He was a lawyer ______ profession, but spent more time ______ literature.
He was a lawyer ______ profession, but spent more time ______ literature.
Explanation
"By profession" is the correct phrase used to indicate someone's official job or career.
"On literature" is appropriate when referring to spending time focused on a subject or activity.